Clarify some things in Objects intro #3721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Signed" makes it sound like you wrote your signature on them or they were cryptographically signed, but that's not the case, so using "labeled" seems like a clearer way to say it.
Using "folder" in the context of a cabinet will be clearer. People know what a folder is; it's not as clear what a file is.
Previously, it had some broken sentences.
Previously, it mentioned wanting to use square brackets. People don't want brackets, they want the flexibility it offers them.
javascript-translate-bot
added
the
review needed
|
|
| @@ -161,7 +161,7 @@ alert( user.key ) // undefined | |||
|
|
|||
| ### Computed properties | |||
|
|
|||
| We can use square brackets in an object literal, when creating an object. That's called *computed properties*. | |||
| If you want to be flexible about naming your properties, you can use something called *computed properties*. | |||
There was a problem hiding this comment.
disagree, Line 164 is clarifying that square brackets are computed properties
| @@ -101,7 +101,7 @@ For multiword properties, the dot access doesn't work: | |||
| user.likes birds = true | |||
| ``` | |||
|
|
|||
| JavaScript doesn't understand that. It thinks that we address `user.likes`, and then gives a syntax error when comes across unexpected `birds`. | |||
| JavaScript doesn't understand that. It thinks that we're referring to `user.likes`, and then gives a syntax error when it comes across the unexpected `birds`. | |||
There was a problem hiding this comment.
How about 'accessing' (used in MDN):
JavaScript doesn't understand that. It thinks that we're accessing
user.likes, and then gives a syntax error when it comes across the unexpectedbirds.
| @@ -7,7 +7,7 @@ In contrast, objects are used to store keyed collections of various data and mor | |||
|
|
|||
| An object can be created with figure brackets `{…}` with an optional list of *properties*. A property is a "key: value" pair, where `key` is a string (also called a "property name"), and `value` can be anything. | |||
|
|
|||
| We can imagine an object as a cabinet with signed files. Every piece of data is stored in its file by the key. It's easy to find a file by its name or add/remove a file. | |||
| We can imagine an object as a cabinet with labeled folders. Every piece of data is stored in its folder by the key. It's easy to find a folder by its name or add/remove a folder. | |||
There was a problem hiding this comment.
file is clear IMO, see File cabinet wiki. i don't think folders is less clear though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few typos or unclear things while I was reading, so I figured I'd leave things better than I found them. I left an explanation for each change in its commit.
Any suggestions are welcome!